legobeat
legobeat
_Somehow GitHub wouldn't dismiss my request for changes (which is resolved) without approving. I haven't actually tested with the logo._
Seems like this is producing/requiring different lavamoat policies depending on if `MULTICHAIN` is enabled or not...
@SocketSecurity ignore npm/@metamask/[email protected] new author ok (says i)
@sahar-fehri 429 Rate-Limiting errors are common for users coming through e.g. Tor or commercial VPN services. As an aside, in general we shouldn't assume availability of these endpoints and fail...
Note: This breaks the peerDependency of `@metamask/signature-controller@^12.0.0` on `@metamask/logging-controller@^2.0.2`. `@metamask/[email protected]` and later use `@metamask/logging-controller` v3. Should these two actually be updated atomically? Potentially related by also being peerDependencies of `@metamask/signature-controller`:...
[Failing `test-deps-audit`](https://circleci.com/gh/MetaMask/metamask-extension/2884270) job addressed in #24664.
Related: - #22859 does a bump from `^21.0.0` to `^22.0.0`
> Code LGTM, but looks to be some problems in CI. Addressed in c81c5033101e32f68b011d9ab91db76db39eff5d by updating tests to expect underlying error message in `cause`.
This error in [`test-e2e-chrome-mv3`](https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/79118/workflows/682fa675-6eeb-48e4-bd12-3d6c6dd4d8e2/jobs/2768626) seems persistent: ``` ``` ~EDIT: Or just flakey test. [Passed after retry](https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/79123/workflows/7dd106c4-6f28-4894-a467-fdccdcdd8702/jobs/2768879)~
Failing `test-deps-audit` job is unrelated: #20697