metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

chore: Bump logging-controller to 3.0.1 and signature-controller to 14.0.1

Open mcmire opened this issue 10 months ago • 16 comments

Description

Specifically, @metamask/logging-controller 3.0.0 relies on a new version of @metamask/base-controller which protects state from being mutated accidentally and includes more type safety for messengers, among other improvements.

EDIT @mikesposito: Since @metamask/signature-controller@<^14 relies on @metamask/logging-controller@^2, the two packages are being updated atomically

See changelogs:

  • https://github.com/MetaMask/core/blob/main/packages/logging-controller/CHANGELOG.md
  • https://github.com/MetaMask/core/blob/main/packages/signature-controller/CHANGELOG.md

Open in GitHub Codespaces

Related issues

Progresses #24140.

Manual testing steps

This upgrade contains no functional changes.

Screenshots/Recordings

(N/A)

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've completed the PR template to the best of my ability
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

mcmire avatar Apr 19 '24 20:04 mcmire

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Apr 19 '24 20:04 github-actions[bot]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 85.9 kB metamaskbot
npm/@metamask/[email protected] None +5 1.74 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

socket-security[bot] avatar Apr 19 '24 20:04 socket-security[bot]

@metamaskbot update-policies

mcmire avatar Apr 19 '24 20:04 mcmire

Policies updated

metamaskbot avatar Apr 19 '24 20:04 metamaskbot

Builds ready [4526c0b]
Page Load Metrics (1699 ± 634 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint693981618842
domContentLoaded1098332512
load56323116991320634
domInteractive998332512
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 12.2 KiB (0.35%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Apr 19 '24 21:04 metamaskbot

Builds ready [e542f7e]
Page Load Metrics (323 ± 355 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint63130952010
domContentLoaded11321963
load522547323738355
domInteractive11321863
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 12.2 KiB (0.34%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Apr 23 '24 20:04 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.40%. Comparing base (640cad4) to head (f3e07a4). Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #24143   +/-   ##
========================================
  Coverage    67.40%   67.40%           
========================================
  Files         1289     1289           
  Lines        50248    50248           
  Branches     13011    13011           
========================================
  Hits         33865    33865           
  Misses       16383    16383

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 24 '24 17:04 codecov[bot]

Builds ready [03e6ac2]
Page Load Metrics (711 ± 539 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint64150932412
domContentLoaded12351963
load5229117111122539
domInteractive12351963
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 12.2 KiB (0.34%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Apr 24 '24 17:04 metamaskbot

Builds ready [6b11978]
Page Load Metrics (927 ± 630 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint621771053014
domContentLoaded107226157
load5035489271312630
domInteractive107226157
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 12.2 KiB (0.34%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Apr 24 '24 18:04 metamaskbot

Note: This breaks the peerDependency of @metamask/signature-controller@^12.0.0 on @metamask/logging-controller@^2.0.2.

@metamask/[email protected] and later use @metamask/logging-controller v3.

Should these two actually be updated atomically? Potentially related by also being peerDependencies of @metamask/signature-controller:

  • #24141
  • #24199

legobeat avatar Apr 29 '24 22:04 legobeat

@metamaskbot update-policies

mikesposito avatar May 08 '24 12:05 mikesposito

As suggested by @legobeat, I included the signature-controller bump to ^14.0.1 in this PR and changed title and description accordingly

mikesposito avatar May 08 '24 12:05 mikesposito

Policies updated

metamaskbot avatar May 08 '24 12:05 metamaskbot

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

socket-security[bot] avatar May 09 '24 21:05 socket-security[bot]

Builds ready [4e8fb25]
Page Load Metrics (969 ± 595 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6213686199
domContentLoaded9261242
load5529729691239595
domInteractive9251242
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 24.64 KiB (0.75%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 09 '24 22:05 metamaskbot

Builds ready [eb9873c]
Page Load Metrics (646 ± 565 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint66152912612
domContentLoaded86217136
load5436016461177565
domInteractive86217136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 24.64 KiB (0.75%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 13 '24 08:05 metamaskbot

Builds ready [f3e07a4]
Page Load Metrics (1026 ± 574 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint68177972813
domContentLoaded10381694
load56306710261195574
domInteractive10381694
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 24.64 KiB (0.73%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 21 '24 10:05 metamaskbot