metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

fix(deps): Bump @metamask/obs-store@^8.1.0->^9.0.0

Open legobeat opened this issue 1 year ago • 6 comments

Description

Bump @metamask/obs-store from ^8.1.0 to ^9.0.0.

The main change is moving from native runtime streams with streamsv2 libraries, to readable-stream@^3.6.2 implementation.

Open in GitHub Codespaces

Related issues

  • #21934

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've completed the PR template to the best of my ability
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

legobeat avatar Apr 24 '24 21:04 legobeat

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Apr 24 '24 21:04 github-actions[bot]

Seems like this is producing/requiring different lavamoat policies depending on if MULTICHAIN is enabled or not...

legobeat avatar Apr 26 '24 08:04 legobeat

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.48%. Comparing base (d27a233) to head (8fb0423). Report is 55 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24233      +/-   ##
===========================================
+ Coverage    67.37%   67.48%   +0.11%     
===========================================
  Files         1278     1288      +10     
  Lines        49881    50153     +272     
  Branches     12944    13023      +79     
===========================================
+ Hits         33605    33841     +236     
- Misses       16276    16312      +36     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 07 '24 10:05 codecov[bot]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 30.8 kB lgbot

View full report↗︎

socket-security[bot] avatar May 07 '24 12:05 socket-security[bot]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

socket-security[bot] avatar May 07 '24 12:05 socket-security[bot]

@SocketSecurity ignore npm/@metamask/[email protected]

new author ok (says i)

legobeat avatar May 09 '24 07:05 legobeat