Justus Sagemüller
Justus Sagemüller
Status quo: plain booleans === Summarized by the signature (I'm treating ODL spaces as if they were types here) ``` space0: some odl.TensorSpace space1: some odl.TensorSpace def __eq__(x: space0, y:...
Boolean spaces === ``` space: some odl.TensorSpace def __eq__(x: space, y: space) -> space.astype(bool) ``` This is in principle the cleanest solution that is consistent with the Array API. The...
Boolean arrays === ``` space0: some odl.TensorSpace space1: some odl.TensorSpace array: plain array type underlying both spaces def __eq__(x: space0, y: space1) -> array[bool] ``` This is how e.g. [`isclose`](https://github.com/Emvlt/odl/blob/2bd2ed6963d4e28b3a4fd447875c2b715be48c81/odl/array_API_support/comparisons.py#L116)...
I'm generally not a fan of linting, and particularly not of Black which in many cases makes the code less readable. As I see it, there are two kinds of...
Would it be possible to run Black to _only_ apply the `.format` and `super` changes?
How long do the tests take to run? It might be good to put most of them, especially the 3D ones, in the "slow" category.
Thanks for submitting! In principle this clear-cut fix can easily be merged - but we decided to avoid touching the `master` branch (except for important bugfixes) until we have finalized...