odl icon indicating copy to clipboard operation
odl copied to clipboard

FBP testing function with different variations of parameters.

Open asalline opened this issue 3 weeks ago • 5 comments

This script runs a tests for Filtered Back-Projection with respect to different parameters, such as geometries, backends, and filters.

asalline avatar Dec 08 '25 11:12 asalline

How long do the tests take to run? It might be good to put most of them, especially the 3D ones, in the "slow" category.

leftaroundabout avatar Dec 08 '25 11:12 leftaroundabout

How long do the tests take to run? It might be good to put most of them, especially the 3D ones, in the "slow" category.

Couple of minutes, haven't timed it. 3D ones certainly slow down the process a lot.

asalline avatar Dec 08 '25 12:12 asalline

Good! Thank you for designing these tests :)

Can you also include the fix to the Ram-Lak filter implementation to this PR?

Emvlt avatar Dec 08 '25 14:12 Emvlt

Oh yes, that is fixed on my local but did not think about pushing it. I will do.

I will have a chat tomorrow with either of you to ask about the "slow" category that Justus mentioned.

I can also push ray transform test with the helical geometry with numpy.

asalline avatar Dec 08 '25 15:12 asalline

@leftaroundabout could you please review the changes and merge if everything fits? Also, should we rebase on master before merging it?

Antti's new test are much more accurate than the existing ones.

Emvlt avatar Dec 09 '25 12:12 Emvlt