Justus Sagemüller

Hello, sorry I missed this issue when it came in; I was on vacation. Notice that Torch is currently not really supported at all; the existing code only contains an...

Would it be a lot of work to put the weighting hierarchy in its own PR? I think there are a bunch of questions to be discussed there, and it...

I did not mean to click "ready for review"

> the classes are refactored but the functionality remain unchanged Well, for one thing, I don't think the current state actually works correctly for a simple inner-product space. In [the...

Pretty sure all that could be fixed, but the thing is, it's not so clear-cut to say the functionality remains unchanged (and whether that even makes sense) given that the...

No critique meant. We're moving in the right direction, I just keep underestimating the amount of individual changes and possible implications. The more we separate concerns, the better we can...

> 2) Deprecating the test that relied on Numpy mechanisms to perform arithmetic operations between product spaces and lists. In my opinion, this should not be supported. It seems that...

> perform arithmetic operations between product spaces and lists so not when x and y are elements of a pspace. Ah, like `x + [4,5,6]` for `x∈ℝ³×ℝ³×ℝ³`? Where exactly is/was...

> See commit https://github.com/odlgroup/odl/commit/2e59ad3da7ac198f3688dee868eed38036e5b765 :) Ah, now I get it! Yes, `y_arr = [op(x_) for x_ in x_arr]` is much better than the old version.

An updated, ready-to-merge version of this PR is now https://github.com/odlgroup/odl/pull/1697, which contains all of the changes originally proposed here. I am closing this PR in favour of that.