Lee Hambley

Results 227 comments of Lee Hambley

I might rather prefer that we put that in new "default command options" map, but yeah, that seems reasonable.

hey @ain nice to run into you again! If you can prepare a patch we'd be quite likely to merge it, I can't yet think of any edge-cases that are...

Thanks @FooBarWidget good call. I'll look at your other PR as well today/tomorrow time permitting. Thanks for taking the time to contribute to SSHKit, I respect you Phusion guys massively,...

> Could this be done like HTML escaping in Rails views, where strings are assumed to be unsafe unless raw or html_safe is explicitly called? I believe this was once...

I looked into this, `taint` unfortunately doesn't work. But I'm going to write a refinement for the `String` and `Symbol` classes that escape them and set a flag when they...

Simple test-cases: ``` ruby require 'test_helper' class Shellwords::Escape::RefinementTest < Minitest::Test using Shellwords::Escape::Refinement def test_trusting_a_string_that_is_equal_to_it_s_escaped_value assert "helloworld".escaped? end def test_not_trusting_a_string_that_is_equal_to_it_s_escaped_value refute "hello & world".escaped? end def test_trusting_a_string_that_is_not_equal_to_it_s_escaped_value_but_force_trusted assert "hello & world".escaped!.escaped?...

Probably both wise decisions, in the end we can choose (once) Freezing the string does seem like a decent idea incase of naming it safe.

/cc @seenmyfate might be that we get support for this into Cap accidentally in the next week or so

Warnings are legit, we should solve them, but if it's only a test problem, I wouldn't let it block you from 1.10 release?

No sorry if the core things don't work for you, don't load them, and rather load replacement. That is a heavy hammer, so you might look at overwriting the `git:wrapper`...