sshkit Improve SSHKit::Host comparison methods

This pull request improves SSHKit::Host comparison in the following ways.

#equal? should test for object identity, not whether the contents are equal, as per the Ruby documentation.
#eql? and #== should check the contents directly instead of comparing the hash. This prevents false positives.

Dec 27 '14 08:12 FooBarWidget

Thanks @FooBarWidget good call. I'll look at your other PR as well today/tomorrow time permitting. Thanks for taking the time to contribute to SSHKit, I respect you Phusion guys massively, and it's a pleasure to receive code from you :)

Jan 05 '15 09:01 leehambley

I'm in the process of closing old/inactive PRs; pardon the noise. This PR seems to have been abandoned. Please comment if you'd like it to be reconsidered.

Sep 14 '16 00:09 mattbrictson

Hey @mattbrictson, why is this patch considered abandoned? There was no feedback on whether the patch is acceptable or not. So at the very least, the patch was not abandoned on my side.

Sep 14 '16 08:09 FooBarWidget

@FooBarWidget: This was just cleanup due to age. Sorry about that. If you don't mind, could you rebase against master, and then we'll try and get this resolved.

Thanks!

Sep 14 '16 13:09 will-in-wi

Looks like we dropped the ball on this PR, then. Sorry about that! Thanks for sticking around. I will try to review this and make a decision whether to merge by the end of the week.

Re-opening.

Sep 14 '16 15:09 mattbrictson