Lee Hambley

Results 227 comments of Lee Hambley

In principal I think I could live with this change. Please have a look at the tests and ensure this behaviour is tested, and also review the contribution guidelines and...

@simon-soak yeah, Rubocop is a moving target, you can safely ignore any errors that were there before your changes based on rubocop `HEAD`, and we'll eventually clean them up

Let's not _move_ anything, but we could definitely copy from, and link to it.

We prefer to keep the API small and tight, there's nothing to prevent you modifying the link step dynamically to replace this with a line you constructed yourself. I'd love...

Thanks for coming back to us. Is it possible that you're not reusing SSH connections or something? And each call to `execute` is actually re-opening a connection? Performance should never...

That actually looks sane, indeed. Do you have `rvm` or something on the server that might make starting a shell slow? Do you tweak Capistrano's config to start a login...

Is this possibly the same issue that you reported in https://github.com/capistrano/capistrano/issues/2023 under a different set of weirdness?

From the output ``` DEBUG [060ab6fb] Command: cd /home/apps/app/shop-lauber-frontend/production/repo && ( export GIT_ASKPASS="/bin/echo" GIT_SSH="/tmp/git-ssh-lauber-frontend-staging-jedrek.sh" ; /usr/bin/env git archive maintenance | tar -x -f - -C /home/apps/app/shop-lauber-frontend/production/releases/20190716095633 ) ``` looks largely...

> Any fix or workaround for this? What environment do you have that claims to be a tty but isn't ? (My guess a badly configured CI server?) My standard...

Same question here, we have either `Driver` or `Client` and I can find no way from the options hash that is yielded to the `token_payload` to the actual owner.