Jiwoo Lee
Jiwoo Lee
I agree with @acordonez that comparison with CMIP5 may not get done by the workshop, but it is good to have the brain storming for the future update. Thanks, @durack1,...
> Does it make sense to have a PMP/PCMDI logo/graphic somewhere up the top of the notebook? (Can you even do that). Just thinking it might be a good template...
Implementation completed, led by @acordonez, and included in [PMP v3.3](https://github.com/PCMDI/pcmdi_metrics/releases/tag/v3.3). Closing this issue.
Close this issue and reopen #710
Progress note: @lee1043 is taking this PR over to finalize it.
It looks like demo notebook 2b boxes [5] and [6] are failing. Debugging is going to be needed. Error message: ``` modpath = modpath_lf = models: ['GISS-E2-H'] number of models:...
Progress note: * The [above-mentioned error](https://github.com/PCMDI/pcmdi_metrics/pull/1022#issuecomment-2111663336) is now resolved. * Demo 2b notebook runs without error. * Verification is going to be needed.
@acordonez I think this PR is pretty much ready. When you get a chance could you please run demo 2b with this PR to see if it runs well?
@acordonez thanks for reviewing and approving. Yes, although it would be nicer if we've got more consistency for the indices, it looks like further in depth investigation might be needed...
All checks passed, merging it now.