Jiwoo Lee

Results 61 comments of Jiwoo Lee

Thanks @durack1 for pointing it out. I've just added "(deprecated)" in the title of the page, but better organization of sidebar and clean up of pages are still required. We...

I am closing this issue because now [README.md](https://github.com/PCMDI/pcmdi_metrics) has been updated to point to documentations for [install](http://pcmdi.github.io/pcmdi_metrics/install.html) and [demo](https://github.com/PCMDI/pcmdi_metrics/blob/main/doc/jupyter/Demo/README.md).

@gleckler1 I think changes should be made in `setup.py` mostly. No other things come to my mind neither.

@acordonez that is a great and very critical point! Thanks for bring that in. In another code (ENSO metric) I have seen the most upper level could be given arbitrarily...

Branch generated: `679_ljw_drought`

- First point still needs work - Second point resolved by https://github.com/PCMDI/pcmdi_metrics/pull/714

@msahn I have made some changes to pass code-formatting check from pre-commit. While I have resolved most of them, followings are still remaining and I need your help to fix...

> I have removed the unused local variables in "lib_precip_distribution.py" but could not fix the issues in "parallel_driver_cmip5.py" and "parallel_driver_cmip6.py". In the codes, ["modpath" and "res" are defined from parameter...

After [adding dependencies in dev.yml](https://github.com/PCMDI/pcmdi_metrics/pull/861/commits/5b8e6a0bf966e10e88b660dccce894ceb06cc541) github action's build test get automatically cancelled every time it was triggered. @acordonez do you have any idea on this? Should we consider specifying versions...

Note: Below four dependencies were added in `conda-env/dev.yml`. I think I can include them as default for now. - `netcdf4=1.6.0` - `regionmask=0.9.0` - `rasterio=1.2.10` - `shapely=1.8.0` However, considering they are...