Jiwoo Lee
Jiwoo Lee
@tomvothecoder sure, I will test it out and review. Thank you for the update!
@tomvothecoder Can this be considered for v0.7.0?
> > @tomvothecoder Can this be considered for v0.7.0? > > This PR still needs thorough review before I'm confident in merging it. I'll probably tag Steve at some point....
@tomvothecoder it looks like when custom season go beyond calendar year (Nov, Dec, Jan) there is error as follows. ```python import os import xcdat as xc input_data = os.path.join( "/p/css03/esgf_publish/CMIP6/CMIP/AWI/AWI-CM-1-1-MR/historical/r1i1p1f1/Amon/psl/gn/v20181218/",...
@mzelinka @pochedls @bosup would you be interested in trying this function that I drafted and share your feedback?
@pochedls glad to learn you already have explored this path! Thank you for sharing the [edge case](https://github.com/regionmask/regionmask/issues/410#issue-1687496840). I haven't hit such issue, maybe the issue you posted is specifically coming...
@pochedls I was able to reproduce the edge case issue you had, so I presume the issue has not been fully resolved. And you are right, the library Mark found,...
Just a note, this capability is implemented to PMP ([here](https://github.com/PCMDI/pcmdi_metrics/blob/main/pcmdi_metrics/utils/land_sea_mask.py)), which I'd be happy to copy it to xCDAT if we decide to implement.
@tomvothecoder As now we can do like this (no specification of axis): `ds = ds.bounds.add_missing_bounds()` How about extending add_bounds() with an override boolean attribute with below options: - default: `override=False`...
My regular code flow in the PMP is like below. As I am dealing with multiple models knowing some models may have their bounds info missed, I use `add_missing_bounds` for...