pcmdi_metrics icon indicating copy to clipboard operation
pcmdi_metrics copied to clipboard

rename /pcmdi_metrics to /summary_statistics

Open gleckler1 opened this issue 3 years ago • 5 comments

@lee1043 @acordonez This simple change may take more work. I expect setup.py will need to be modified. Any other things come to mind before I get started?

gleckler1 avatar Apr 09 '21 18:04 gleckler1

@gleckler1 I think changes should be made in setup.py mostly. No other things come to my mind neither.

lee1043 avatar Apr 09 '21 18:04 lee1043

@gleckler1 @lee1043 All the package references in our scripts would need to be updated, e.g. from pcmdi_metrics.monsoon_sperber.lib import sperber_metrics would need to be from summary_statistics.monsoon_sperber.lib import sperber_metrics

acordonez avatar Apr 09 '21 18:04 acordonez

@lee1043 @acordonez and maybe in some codes like below? ...

https://github.com/PCMDI/pcmdi_metrics/blob/master/pcmdi_metrics/diurnal/scripts/compositeDiurnalStatistics.py#L26

gleckler1 avatar Apr 09 '21 18:04 gleckler1

@acordonez that is a great and very critical point! Thanks for bring that in. In another code (ENSO metric) I have seen the most upper level could be given arbitrarily instead of directory name.

e.g.: https://github.com/CLIVAR-PRP/ENSO_metrics/blob/903f12a416b21f56f745001ae9ed2ebbf65bc779/pmp_driver/PMPdriver_EnsoMetrics.py#L19

and

https://github.com/CLIVAR-PRP/ENSO_metrics/blob/903f12a416b21f56f745001ae9ed2ebbf65bc779/setup.py#L61

I don't know if we can do something similar here. We may need some study on it.

lee1043 avatar Apr 09 '21 18:04 lee1043

@lee1043 @acordonez I'll try it out on a branch and keep you posted.

gleckler1 avatar Apr 09 '21 18:04 gleckler1