Panos Sakkos

Results 14 comments of Panos Sakkos

@djcaesar9114 good stuff! How about creating a script with your two commands in order for the existing users to migrate to pygments? 😉 Also, we should remove the highlight.js dependency...

@eiselems @joariasl This is a really good PR, let's test it and merge it to master 😉 No need for a migration script is needed 😄

Good point. I [asked](https://twitter.com/thepanoss/status/688467265164042240) them and I will update the issue here when they reply.

@dwendt Thanks for the suggestion! Can you please briefly list the benefits of pygments over the current solution?

The reason that bootstrap (i.e.) is served from the cdn is that @joariasl believed that it's more efficient than serving the minified versions from the { Personal } server. Personally...

The images should be square in order to be rendered correctly, but I like that you're trying to tackle that problem. Did you come up with a good enough solution?

Thanks Alexander. And what is the expected behavior when trying to write more data than a qr code can handle? Shouldn't there be a test that covers that case? :shipit:

We haven't decided if we will choose your library for our product yet, so I can't commit on paying your test debt, yet :smile:

> This is correct. Although I think the intention of @yankodimitrov was to leave this implementation detail to the implementors. It's not mentioned in the readme file, which makes it...

Opened a [PR](https://github.com/codicocodes/dotfyle/pull/90) in case the `html` and `graphql` must be removed.