personal-jekyll-theme icon indicating copy to clipboard operation
personal-jekyll-theme copied to clipboard

Pygmentation

Open djcaesar9114 opened this issue 8 years ago • 6 comments

Issue Fixed #138

Proposed Changes

  • I changed the hard coded parts (<pre><code> etc.) with pymented ones ({% highlight etc.)
  • I used:
  1. grep -rl '<pre>' . | xargs sed -ir 's/<pre><code\ data-trim\ class="\([a-z]*\)">/\{% highlight\ \1\ %\}/g'
  2. grep -rl '</code>' . | xargs sed -ir 's/<\/code><\/pre>/\{% endhighlight %\}/g'

djcaesar9114 avatar Aug 22 '16 19:08 djcaesar9114

@djcaesar9114 good stuff! How about creating a script with your two commands in order for the existing users to migrate to pygments? 😉

Also, we should remove the highlight.js dependency now that we're switching to pygments.

le4ker avatar Oct 16 '16 22:10 le4ker

OK, got it! I'm on it ;)

djcaesar9114 avatar Oct 18 '16 20:10 djcaesar9114

@eiselems @joariasl This is a really good PR, let's test it and merge it to master 😉

No need for a migration script is needed 😄

le4ker avatar Apr 18 '17 20:04 le4ker

@djcaesar9114 is there still work left to be done (besides the merge conflict)?

eiselems avatar Jul 02 '17 16:07 eiselems

Good to go ;)

djcaesar9114 avatar Jul 03 '17 07:07 djcaesar9114

haha shit :/

eiselems avatar Jul 08 '17 20:07 eiselems