Christoph Daniel Schulze

Results 68 comments of Christoph Daniel Schulze

I'm not sure how the first proposal would solve the problem. The latter proposal, however, seems sensible to me. An `IParametersProvider` would be called after the layout connector has built...

The user tried building a `Parameters` object inside the `DiagramLayoutEngine` since he couldn't figure out where to cobble that together. It then dawned on me that the place to configure...

This needs to be coordinated with downstream projects and is thus, for the moment, postponed.

I actually haven't seen the issue since, so I'm closing this.

Sorry, I totally neglected this ticket. I'll be sure to take a look at it over the next few days.

Right, I've spent a few minutes looking into this and have a few comments. Hierarchy handling should only be necessary for _long_ hierarchical edges. What you seem to have here,...

According to my last comment here, this was related to eclipse/elk#369, which has since been fixed. Is there anything else I need to look at?

> I reduced the original example a bit and (hopefully) moved the edges to correct containment As I mentioned in my previous comment, proper edge containment is just one half...

> Shouldn't the ports (dummies) be added automatically? With `INCLUDE_CHILDREN`, they in fact are. Without that option, they are not, but should be. There's a ticket about that, namely eclipse/elk#60....

No, we can't, due to eclipse/elk#328. I'll link back to this issue for another set of examples that demonstrate parts of that problem.