Christoph Daniel Schulze comments

Results 67 comments of


                                            Christoph Daniel Schulze

Add test to actions verifying that all example models are laid out correctly

What do you mean by "example methods"?

Add test to actions verifying that all example models are laid out correctly

Still not sure what you're referring to here, though. 😄

Add test to actions verifying that all example models are laid out correctly

Ah! Makes sense.

Add test to actions verifying that all example models are laid out correctly

That's an excellent idea. We'll keep the idea around, although I'll better refrain from assigning it a milestone...

HierarchyHandling problematic when directly using layout provider

We could put that logic into a public utility method which is then also used by the `RecursiveGraphLayoutEngine`?

HierarchyHandling problematic when directly using layout provider

Well, if the `RecursiveGraphLayoutEngine` is used the answer is rather obvious. If people call layout algorithms directly I think it's fine to require them to call said method beforehand. First,...

HierarchyHandling problematic when directly using layout provider

We should evaluate how this relates to #314.

HierarchyHandling problematic when directly using layout provider

Yes, we were thinking along those lines. Since that requires a bit of thought I don't expect that will happen for the next release.

Plain java hierarchical layout yields NPE in HierPortPosProcessor

> @le-cds any idea which ticket could have solved this? Perhaps the orthogonal edge router refactoring, but I'm really not sure.

More flexible 'requires' element in elkm files

I understand (and support) the desire to generalize lower and upper bounds, but I think allowing arbitrary implementations for dependencies takes a bit too far. After all, the use case...