elk icon indicating copy to clipboard operation
elk copied to clipboard

Add test to actions verifying that all example models are laid out correctly

Open uruuru opened this issue 5 years ago • 9 comments

uruuru avatar Jul 31 '20 09:07 uruuru

What do you mean by "example methods"?

le-cds avatar Aug 03 '20 09:08 le-cds

Sorry, misstyped that one ...

uruuru avatar Aug 03 '20 11:08 uruuru

Still not sure what you're referring to here, though. 😄

le-cds avatar Sep 16 '20 11:09 le-cds

These ones: https://rtsys.informatik.uni-kiel.de/elklive/examples.html

uruuru avatar Sep 17 '20 18:09 uruuru

Ah! Makes sense.

le-cds avatar Sep 22 '20 21:09 le-cds

These ones: https://rtsys.informatik.uni-kiel.de/elklive/examples.html

I discovered this page. It is great. Is it a project to have similar examples on each option in the reference documentation? For example for Comment Box, it will be interresting to have this example to illustrate it.

lredor avatar Sep 23 '20 08:09 lredor

@lredor there are no clear plans. I created the basis and was hoping that "people" (including me) find time to add an example once in a while.

The examples are described in a single file in a simple text format, are added to the elk models repo and then automatically deployed to the website. See https://github.com/eclipse/elk-models/tree/master/examples Everyone is encouraged to add simple examples where sensible.

Regarding your suggestion to add the examples to the reference documentation. The documentation website is created via a static site generator and I wouldn't include the layouter and a rendering engine there (if at all possible given eclipse guidelines). I must admit that I have thought about somehow merging the two sides before, though.

uruuru avatar Sep 23 '20 20:09 uruuru

We could add a list of links to available examples to the layout options in the reference documentation. The models repos is available during website construction. Given a base-url it should thus be possible to assemble the relevant links.

uruuru avatar Sep 24 '20 05:09 uruuru

That's an excellent idea. We'll keep the idea around, although I'll better refrain from assigning it a milestone...

le-cds avatar Oct 16 '20 10:10 le-cds