Leonardo Collado-Torres

Results 133 comments of Leonardo Collado-Torres

Thanks everyone for this thread! This works again as you can see at https://github.com/lcolladotor/biocthis/actions/runs/3364123000/jobs/5578109324#step:30:90 ^^ I tried adapting some of https://github.com/r-lib/actions/blob/465e3c76cf4d432b547a0a411972939899c87857/examples/pkgdown.yaml#L40-L46 as suggested by you earlier, but also using `JamesIves/github-pages-deploy-action@releases/v4`...

Hi! @madhavitippani and I ran into this issue and we also resolved it by installing the GitHub version of `harmony`. In particular, from `sessioninfo::session_info()` I have: ```R harmony * 0.1.0...

Hi, I just wanted to check if you have plans on updating `harmony` on CRAN to resolve this issue. I understand well that maintaining software is challenging and greatly appreciate...

It's been nearly 2 years since this conversation started. Maybe we can talk about it at BioC2023? Or maybe the BioC core has an updated policy on this?

Hi, I'm not a fan of pasting numbers since you might want to re-order the samples later and thus "sample 1" might become "sample 10". This happened to us in...

Well, I guess that you could already re-run the code that pastes numbers based on the sample ids to fix the issue I have. Here's a full `reprex` of what...

That's why I prefer to use the `sample_id` from the beginning instead of numbers whose meaning might change, in the process of creating those unique spot/column identifiers in the `spe`...

FYI After my initial comment https://github.com/drighelli/SpatialExperiment/issues/100#issuecomment-1047845022 I ended up making `spatialLIBD::add_key()` to reduce code duplication and add the `overwrite` parameter https://github.com/LieberInstitute/spatialLIBD/blob/master/R/add_key.R.

## Re @PeteHaitch's comment on `spe` not having `spe$Barcode` I would benefit from having it listed, despite the duplication in information. So I +1 his request about it. I would...

Hi! We'd love to submit a PR about this functionality since we think that it would be a good companion to the `rotateImg()` and `mirrorImg()` functions that already exist in...