Lorenc Bushi

Results 42 comments of Lorenc Bushi

> > It is complete except that it does not verify that the forward progress guarantees requested by a kernel submission are actually supported by the device to which the...

I've refactored the device_impl.{hpp, cpp} files and implemented verification of the forward progress requirements in the handler.{hpp, cpp}.

@intel/llvm-reviewers-runtime ping for review

@intel/llvm-reviewers-runtime second ping as all pre-commit tests are now passing. The PR is somewhat big but 400 lines are tests.

@intel/llvm-gatekeepers This is ready for merge.

@intel/llvm-gatekeepers The PR is now approved. The AWS failures are unrelated to my PR.

This has introduced post-commit errors which are being addressed by https://github.com/intel/llvm/pull/13793/

> Overall, the PR LGTM. I can approve the changes once the corresponding UR PR gets merged and we accordingly update the UR tag. Thanks, will ping you once the...

UR PR: https://github.com/oneapi-src/unified-runtime/pull/1569