llvm
llvm copied to clipboard
intel
[SYCL][L0] Bump UR tag to test USM allocation functions fix for non-power of 2 alignments
I've opened a PR in UR that fixes an issue where USM allocation functions are returning non-null pointer values when called with alignment values that are not powers of 2 on L0 devices. This contradicts SYCL spec and Level Zero spec. This PR changes the UR tag to the commit in my UR repo fork to test the fix. After that UR PR is merged, I'll update the UR tag to include my changes.
Overall, the PR LGTM. I can approve the changes once the corresponding UR PR gets merged and we accordingly update the UR tag.
Thanks, will ping you once the UR changes go through.
Overall, the PR LGTM. I can approve the changes once the corresponding UR PR gets merged and we accordingly update the UR tag.
@uditagarwal97 please rest assured that the intel/unified-runtime-reviewers team, as code owners of sycl/plugins/unified_runtime/CMakeLists.txt, will handle this correctly. Requesting changes to block PR's like this actually makes our job harder managing the UR merge backlog by stopping us being able to approve and merge intel/llvm PRs asynchronously once we merge changes to UR main branch. Note we are mostly in Europe, so time zone delays can have a big impact on forward progress.
Overall, the PR LGTM. I can approve the changes once the corresponding UR PR gets merged and we accordingly update the UR tag.
@uditagarwal97 please rest assured that the intel/unified-runtime-reviewers team, as code owners of
sycl/plugins/unified_runtime/CMakeLists.txt, will handle this correctly. Requesting changes to block PR's like this actually makes our job harder managing the UR merge backlog by stopping us being able to approve and merge intel/llvm PRs asynchronously once we merge changes to UR main branch. Note we are mostly in Europe, so time zone delays can have a big impact on forward progress.
Sure, that makes sense. I'll approve the PR.
@lbushi25 https://github.com/intel/llvm/pull/13658 has now merged, please pull in the latest changes from the sycl branch and resolve the conflict.
PR title says "Bump UR tag to test USM allocation functions fix for non-power of 2 alignments", but I don't see any UR tag changes in the diff. @lbushi25, could you update the PR's title and description, please?
PR title says "Bump UR tag to test USM allocation functions fix for non-power of 2 alignments", but I don't see any UR tag changes in the diff. @lbushi25, could you update the PR's title and description, please?
Thanks, missed that. I've changed the description and title. Also, I'll ping again when the CUDA precommit test is finished as it restarted.
It has come to my attention that a very similar test is already in the repo so I just removed an // UNSUPPORTED: gpu line in that test to reflect that the bug has been fixed and that should be it for this PR.