lberki

Results 220 comments of lberki

@laurentlb , @laszlocsomor , what do you think? The main blockers I see is that RBE doesn't support this yet (the protocol itself does, but we haven't wired it up...

Try `//third_party/bazel/src/test/shell/bazel:bazel_unresolved_symlink_test`. I admit I haven't tried it on Windows. There is a chance that it works since all that's needed is `ActionMetadataHandler#fileArtifactValueFromArtifact()` to work which in turn only needs...

...oh, and `Path#createSymbolicLink()` for `SymlinkAction#execute()`.

Looking at the history of this issue, the main blockers seem to be Windows and RBE support. Once those are fixed (or we decide that they don't matter), we can...

@meteorcloudy then that leaves RBE support, I guess. (plus some glue logic to hard-wire the value of this flag to false within Google, but that, I can throw in since...

Bumping this down to P2 to indicate our collective desire to get this into Bazel 6.0, but also that we won't postpone the release cut for this, should this and...

@brandjon Do I understand correctly that these two issues are blockers for this one: https://github.com/bazelbuild/bazel/issues/16323 https://github.com/bazelbuild/bazel/issues/16355 ?

I seem to remember trying with 0.28 and finding the same breakage.

`test_coverage_on`? I thought that the output error indicated completely broken coverage collection in 0.28, but maybe I misread it?