LB (Ben Johnston)

Results 1054 comments of LB (Ben Johnston)

Update * Have gone with a way simpler approach now * When a warning is triggered - it always dispatches a custom event * The functions now use a bit...

As per https://github.com/wagtail/wagtail/issues/8956#issuecomment-1218812369 and response - probably not really a useful requirement for now. Will close this and can revisit in the future if this is something helpful to those...

Thanks for the heads up @KittyGiraudel - appreciate your work on this awesome modal package.

Will change to discrete events.

Rework of #8900 with a bit of a clearer build upon #8957 & without changing the current preview shortcut. Turns out - finding a shortcut is hard - will need...

I do not think the failing CI is from this PR ``` /usr/bin/docker pull mysql:8.0.23 Error response from daemon: Head "https://registry-1.docker.io/v2/library/mysql/manifests/8.0.23": Get "https://auth.docker.io/token?account=githubactions&scope=repository%3Alibrary%2Fmysql%3Apull&service=registry.docker.io": EOF Warning: Docker pull failed with exit...

Not sure but this issue may be related. https://github.com/wagtail/wagtail/issues/8915

Also added a note that we should use a colour that already exists in the colour variables. As for the note about what the 'gold' means - preference would be...

Workflow history detail will be solved via https://github.com/wagtail/wagtail/pull/8626

RFC 78 created https://github.com/wagtail/rfcs/pull/78 - with the goal of giving us a practical solution to widget scripts (amongst other things).