LB (Ben Johnston)

icon indicating a website link https://lb.ee icon indicating an email [email protected]

icon company Virgin Australia icon location Brisbane, Australia icon location LB (pronounced ‘Albi’), love coffee, systems, travel, technology and also coffee. Incredibly thankful for my amazing wife Bec and son Leo.

Results 1054 comments of LB (Ben Johnston)

Raise an error when an indexed field is not found

@przemub could you take a look at the failing tests, seems to be elastic search only

Separate components JavaScript into distinct folders

@kaedroho there is a really really rough WIP frontend development documentation here https://docs.google.com/document/d/1P_ckY9GKc1V8_pvWTAqXoQ3h3NFcFbBngkPeJv-vBtg/edit It will hopefully help us be clear about what frontend stuff goes where / what folder and...

Aliases don't show nested related items

Thanks for adding details and confirming this @mehrdadmoradii

Searching documentation returns no results for pinned versions

Yeah, looks like the search does not work for versions but it does for stable/latest * ✅ https://docs.wagtail.org/en/latest/search.html?q=image# * ✅ https://docs.wagtail.org/en/stable/search.html?q=image# * ❌ https://docs.wagtail.org/en/v2.16.1/search.html?q=image# * ❌ https://docs.wagtail.org/en/v2.15.4/search.html?q=image# Not sure if...

Built-in accessibility checker for Wagtail: Sa11y

A few thoughts * sa11y looks great and agree it seems well purposed to help with CMS previews * If this is not going to be a third party package...

Provide a guideline for any APIs/interfaces that use a `classname` to render HTML classes

PR https://github.com/wagtail/wagtail/pull/8886

Add preferred naming convention of `classname` to coding gudelines + refine some existing usage

Rebased

When running manage.py loaddata setting locale to Locale.get_default() is wrong.

Thanks for submitting this @specialunderwear I have flagged for a review.

Refactor Avatar styles into UI component

Update: Ignore this - ~~While we are at it. It would be good adopt `w-avatar` as the class and adopt BEM classes if needed.~~ There is also this PR that...

Refactor Status tag styles into UI component

We should also try to refactor the CSS to be consistently using the `w-` prefix and move styles files from scss/objects to scss/components