LB (Ben Johnston)
LB (Ben Johnston)
As I know we will want to tackle the keyboard shortcuts stuff better in the coming release or so I have updated the Stimulus adoption issue to be both simpler...
Great, I might raise a new issue that covers this smaller scope with a bit of direction, hopefully with enough detail for a new-ish contributor to work with.
https://github.com/wagtail/wagtail/issues/11711 has been raised for a very basic initial version of the keyboard shortcuts dialog. I have also updated this issue's description with a bit of an action plan and...
@benenright - any chance you could add a comment with the keyboard icon svg?
We may also want to consider some guidelines in our documentation for how to create accessible keyboard shortcuts. See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-keyshortcuts Also, the guidelines on that MDN page advise against overriding...
Also adding this comment from @zerolab > I stumbled upon https://github.com/ai/keyux the other day and thought of this issue ([source](https://twitter.com/sitnikcode/status/1760677051127021887)) It's a nice looking library that also has some great...
https://github.com/wagtail/wagtail/pull/11740 has been merged & https://github.com/wagtail/wagtail/issues/10167 has been closed. The next steps can be started if anyone is keen, specifically adding a new set of keyboard shortcuts for the sidebar,...
Closing this as the main goal (small cleanup & Dev docs) has been done via https://github.com/wagtail/wagtail/commit/30585340fd020391aae6d406b02aea4ab73c4177 https://github.com/wagtail/wagtail/pull/8886
@allcaps - just seeing if you might be keen on reviewing this one
Updated this issue's title to reflect that there are some other issues with the integration / Axe tests. This failure below (see https://github.com/wagtail/wagtail/pull/11431#issuecomment-1885836807 ) was saying that the button must...