Laytan

Results 212 comments of Laytan

> > Also can someone look at why `core:crypto` test is failing? I believe I haven't touched it > > Think this is an issue with the CI worker being...

https://github.com/odin-lang/Odin/blob/fd582015fe2bbaabc42f78caefec1bd95f4d1465/src/gb/gb.h#L482 Should be `#if defined(_MSC_VER) && !defined(__clang__)` I think

You are not using futexes correctly here. `futex_wait` accepts the expected value currently at the given futex as its second argument, you are giving it `0` every time now, and...

> What would be the alternative solution? Creating threads at testing.runner that can be passed each test and replaced as necessary if they timeout? That would be ideal I think,...

> Does the thread pool implementation in the threads package need improvement, or are there special requirements for a test runner thread pool? I had a look for issues regarding...

This is a weird one? Why would we need to change things here? We don't want to run on the latest and greatest llvm in our ci because we also...

> > This is a weird one? Why would we need to change things here? > > to match with the homebrew build? Alright, but for the reasons I stated...

I would be fine with a matrix, I don't have final say here though

This very much looks like the error you get running llvm 18, that pass was renamed in that version. Although I see your report says 17

Almost done, but I would also like to be able to "subscribe" multiple connections to one event stream