Laytan

Results 212 comments of Laytan

Still a bug in the way `odin run` forwards arguments so I won't close it

This repo is on a bit of a feature freeze while we work on getting http into Odin core. The version thats wip for that already has some streaming and...

I agree, would be a good addition

Closing a file in os2 does a little more, it also frees and zeros memory. You are effectively testing a use-after-free where all bets are off. I did put in...

> In that case, do we not need an Invalid_Stream error? I don't think it is needed, but it could be hit when somebody does `os2.fd(file)` to get the underlying...

Looks good to me! I just remembered that `bufio` also has some streams but we can also add those in the future.

> It also looks like this has revealed an issue with EOF detection in os2 Windows. I suspect that the note in os Windows about a successful read meaning a...

Hmm looks like ubuntu CI is deadlocking now for some reason, ran it twice and it deadlocked at the same spot 🤔

Looks like a deadlock in `os2/heap_linux.odin:602`, only on running the tests with multiple threads, looks like a bug in that allocator.

`-sanitize:thread` is not happy with the allocator: ``` WARNING: ThreadSanitizer: data race (pid=12498) Read of size 8 at 0x0000019553b0 by thread T1: #0 os2._region_retrieve_with_space-5869 /home/laytan/third-party/odin/core/os/os2/heap_linux.odin:515:8 (io+0x553368) (BuildId: ad0ef22dbbcb61f9cfde8845c7e7c7f436b36459) #1 os2.heap_alloc-5760...