Lawrence Forooghian

Results 63 comments of Lawrence Forooghian

I remember that we discussed this internally but I don't remember if it was in Slack (can't find it) or just in a standup. Do you remember? I remember mentioning...

Ah cool, seems like you can type in a dummy tag name in the "choose a tag" field 👍

I’m assigning a high priority to this bug since it presumably affects all of the users who are compiling our library, which I think is most of our users. And...

To be clear here, this should be done once the contents of https://github.com/ably/ably-cocoa/pull/1293 *have been released*.

Is this a code quality issue or a user experience issue? I’m not sure what you mean by "it makes the code very bulky".

I think that writing tests is a pretty subjective thing and there frequently isn’t really a "right" way to do it — I was satisfied with the way I did...

I tried running the actions from this branch on my fork and all of the jobs are passing. Has cookiejar been fixed upstream?

Sorry @VeskeR, didn't mean to assign this to me. Have assigned it back to you.