lawnjelly

Results 160 comments of lawnjelly

If you are still having a problem, please include a minimum reproduction project and I can take a look. :+1:

Sorry it took a while to look at this, I must have missed the reply (being away from home). On latest master, first thing I did was lower the physics...

See #29 . This was actually the old behaviour before using `set_as_toplevel`, if I remember right. Only for the reason that when I originally wrote the addon 4 years ago,...

No, there's no support for this in `splerger`, it doesn't handle bones / weights, it is actually very simple (core merging handles a lot more cases). If someone else wants...

The name `set_rotation()` seems a little of a cop out, given that quaternions are usually rotations, and there are multiple ways of setting them (e.g. axis angle etc). Would `set_shortest_arc()`...

I *think* shortest arc is probably the best term. There is also "great circle arc" and "minor arc" but shortest arc seems to convey what we are after. Double checking...

> Besides the naming I want you to be aware of https://github.com/godotengine/godot/issues/80249, see my comment: https://github.com/godotengine/godot/issues/80249#issuecomment-1666581678 (seems still relevant). Yes the input could be verified (at the least in `DEV_ENABLED`)....

> @lawnjelly @reduz can we setup a discussion on contributors chat for this stuff? I feel like I'm really lost with whats going on with this stuff as of late,...

Just to note briefly discussed this this morning: > lawnjelly 9:43 AM [reduz]() I've been having a bit of a look at PoolVector in 3.x. I realised you have changed...

Just to note we discussed this yesterday on rocketchat: This PR is using `LocalVector` rather than `Vector`. `LocalVector` has no COW or refcounting, and PoolVector uses a different COW solution....