Lauri Tulmin

> will someone from the team merge it? yes, maintainers will merge

@zeitlinger could you rebase so this could be merged

The title of this issue is misleading. I initially thought that this is about tests in https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/spring/spring-kafka-2.7 but it is really about https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/spring/spring-boot-autoconfigure/src/test/java/io/opentelemetry/instrumentation/spring/autoconfigure/instrumentation/kafka/KafkaIntegrationTest.java

> no tests are changed. Do we write tests for advices? not really sure what you mean. We don't test individual advice classes, but we test whether applying instrumentation has...

Please provide instructions on how to run trino in a way that would allow connecting jconsole.

try ``` --- rules: - bean: trino.memory:name=general,type=MemoryPool mapping: FreeBytes: metric: otelcol_trino_memorypool_freebytes type: gauge desc: Pool memory freebytes unit: By ```

@fabjesus look at the output from the logging exporter. It should contain something like ``` ScopeMetrics #3 ScopeMetrics SchemaURL: InstrumentationScope io.opentelemetry.jmx Metric #0 Descriptor: -> Name: otelcol_trino_memorypool_freebytes -> Description: Pool...

@fabjesus please provide detailed instructions on how this could be reproduced. Start the instructions from downloading trino. For example download https://repo1.maven.org/maven2/io/trino/trino-server/445/trino-server-445.tar.gz create configuration file `etc/config.properties` with content ... etc. launch...

> I think kafka instrumentation should record [cluster-id](https://kafka.apache.org/20/javadoc/org/apache/kafka/clients/admin/DescribeClusterResult.html) as a server.address or [node host](https://kafka.apache.org/20/javadoc/org/apache/kafka/common/Node.html) if it can retrieve them. Will bring it up in messaging semconv to decide which one....

I find it unlikely that the bug is in this project. Our ktor instrumentation doesn't do much with the context, it relies on https://github.com/open-telemetry/opentelemetry-java/tree/main/extensions/kotlin for propagating the context. After debugging...