Lauri Tulmin

Results 218 comments of Lauri Tulmin

How large are these sql statements? Multiple megabytes?

> It seems you have missed some similar cases, such as in https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/oshi/library/src/main/java/io/opentelemetry/instrumentation/oshi/ProcessMetrics.java and https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/oshi/library/src/main/java/io/opentelemetry/instrumentation/oshi/SystemMetrics.java I don't wish to change anything in the oshi instrumentation in this PR.

Our netty instrumentation does not support tracing http/2 requests yet.

@vishaltk miconaut specific instrumentation is needed for better route support

@vishaltk I'd imagine that it would involve instrumenting micronaut code and inserting a call to `update` in https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/semconv/http/HttpServerRoute.java

Could you provide a minimal sample application that reproduces the issue so it would be easier for us to debug this.

Resolved with https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/13414 and https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/13423

Unfortunately, they way I see it, this PR can not be merged as it is. Have a look at https://opentelemetry.io/docs/specs/semconv/database/ Pay attention to > Warning Existing database instrumentations that are...

> As far as I see the agent doesn't support this feature nor it can be configured in an extension. Could you elaborate what prevents you from configuring it from...

> Multi-document properties allow the same configuration property to be present multiple times inside application.properties and the actual resolved value is dependent on some condition Agent needs to figure out...