Laurent Le Brun

Results 137 comments of Laurent Le Brun

There are a few options for the implementation: * Update `new_load` to remove the previous conflicting definitions. * Add a new command `remove_load` (to be combined with `new_load`). * Add...

`buildozer "new_load bar.bzl x"` could remove the previous definition of x. In your example, `"y"` was replaced with `"a"`, is it intentional? If so, do you want to rename all...

Buildozer CLI was originally designed for dealing with .bzl files. If the variable is used in target of the BUILD file and you want to edit the target, `--edit-variables` can...

Hi, why do you need this? I thought checking for Bazel/Buck/Pants files would be enough. Is there another scenario? Thanks

I would prefer to avoid adding a new flag for that. Is it an option to rename your files in the old repo?

There are still issues with these flags: * `--incompatible_new_actions_api` * `--incompatible_no_support_tools_in_action_inputs` * `--incompatible_disable_deprecated_attr_params` * `--incompatible_disallow_load_labels_to_cross_package_boundaries` * `--incompatible_disallow_dict_plus`

We plan to fix some of these flags soon in Bazel.

`--incompatible_disallow_dict_plus` is now enabled in Bazel at head.

From the latest CI run: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/28#866e8cd5-7e69-46bf-a8d0-4ec6e9188937 Migration is needed for the following flags: * --incompatible_allow_python_version_transitions * --incompatible_bzl_disallow_load_after_statement * --incompatible_depset_is_not_iterable * --incompatible_depset_union * --incompatible_disable_deprecated_attr_params * --incompatible_disable_legacy_cc_provider * --incompatible_disable_legacy_proto_provider * --incompatible_disallow_load_labels_to_cross_package_boundaries *...

Can you provide an update for `--incompatible_depset_is_not_iterable`, `---incompatible_depset_union` and `--incompatible_disable_deprecated_attr_params`? For `incompatible_disable_deprecated_attr_params`, try to update protobuf to 3.7.1 (like here: https://github.com/bazelbuild/rules_closure/pull/344).