Laurent Le Brun

Results 137 comments of Laurent Le Brun

Can you give more information on your setup? What tool is compiling the code? Have you considered filing a bug against that tool? As far as I can tell, the...

Do you have a simple repro? What might happen is that you define a variable like `float m=10` and it got inlined. The workaround is to declare it as `float...

Thanks! An issue is that we lose type information when we inline (the value is an int, but the variable is a float), similar to https://github.com/laurentlb/Shader_Minifier/issues/323#issuecomment-1966687387

From the [Python manual](https://docs.python.org/3/reference/lexical_analysis.html#literals): > Changed in version 3.6: Unrecognized escape sequences produce a DeprecationWarning. In some future version of Python they will be a SyntaxError. I'd propose to make...

cc @Quarz0 @alandonovan We'd like to make this change in Bazel soon.

Agree. My comment was unclear, I wanted to suggest only the syntax error (Bazel has a way to roll out incompatible changes without using warnings).

Yes, I also prefer the first one. You may add `allow_empty=False` to `srcs`.

Thanks for the report, this is surprising. Can you look at the functions before minification, and check their signature? They have exactly the same list of arguments?

Thanks for the report, this is very useful! We've just investigated, it's a bug in the parser, that leads to funny things in the inlining and renaming passes. Workaround: use...