Laurent Le Brun

I don't think we should accept anything else than a boolean. (Python doesn't have a clean distinction between ints and booleans for historical reasons)

The Java implementation doesn't allow integers in place of booleans. ``` File "/tmp/bazel/BUILD", line 2, in print "".splitlines(0) expected value of type 'bool' for parameter 'keepends', in method call splitlines(int)...

Yes, Bazel native rules do that (with attr.bool), because it was created at a time when there was no booleans at all. I don't think it's useful to support that...

The fact that some native functions in Bazel don't behave well shouldn't impact everyone else. Using 0 and 1 is discouraged: https://docs.bazel.build/versions/master/skylark/bzl-style.html#boolean-values

What's the use-case for the `prefix` argument in `json.indent`?

Using docstrings is also my recommendation for now. Yes, it's more verbose (but it also encourages users to write documentation), but it seems safer to me as I'd rather not...

Good catch! The Go implementation doesn't seem very consistent: ```python (a) = 5 # okay (a) += 1 # fails ``` Both statements are allowed by the Java implementation (used...

> I like the description of "exported-ness" as a simple consequence of splitting the module block into an outer publicly visible block and an inner locally visible block. I agree....

I'm happy to review a PR updating the spec.

It's not valid: > It is a static error to bind a global variable already explicitly bound in the file