Martin Harriman

Thoughts regarding LevelDB and key-value stores: - IOfflineStorage (and the packager, as a consumer of records from the storage observer) use not-just-key-value queries, and in particular query on the latency...

The very short answer is yes, we should decouple these (and other similar methods) from httpClient.java and initialize all the PAL-layer android code without reference to httpClient.

Why not explicitly allow Initialize() to allow it to do the "logger for Token2" dance? Also also, I would be just ever so delighted if the exciting pointers and instances,...

As things stand now, GetAndReserveRecords (bless it) pulls lower-latency, higher-priority events first and only pulls from eligible-for-upload latencies. Both the SQLite and Room databases permit the engine to optimize the...

I should also say that on mobile, DB read is a low energy, low-impact operation. It's not as if there's an IBM 3330 spinning a massive disk pack with a...

**Thread Pools** The Android implementation uses a Java-world fixed thread pool (infinite queue feeding two threads) to run https requests. **Unique task id** It would be delightful if the unique...

The iOS teams client is crashing at 0.07% of sessions, likely with a related problem. The most recent stack trace shows an upload job crashing with use-after-free because the config...

I'm not familiar with the iOS HTTP stack. On Android, process exit (and not much else) can reliably cancel the thread executing the synchronous HTTP call, so the implementation is...

Three of the strings called out in the example report are keys in a configuration object. I would certainly expect the configuration maps themselves to allocate before the first document...

@lalitb is correct: OfflineStorageTests_Room tests SQLite and Memory on all platforms, and SQLite, Memory, and Room on Android (the Android unit test image links both Room and SQLite). OST_R was...