larsrc-google
larsrc-google
@vladmos Are these names (`arm64`, `amd64`) chosen arbitrarily or to match some other usage? `amd64` seems particularly odd.
Thank you. You missed one comment from before, and I added a couple small things.
I don't see the zeroing happening in `executorInit()`, only in `buildComplete()`. If you zeroed them in `executorInit()`, that would be sufficient.
Sorry, not familiar with this code base nor with Go.
No, it was submitted as cl/498557024 on Dec. 30. -Lars On Thu, 23 Feb 2023 at 11:46, Xùdōng Yáng ***@***.***> wrote: > Was this only merged into the 6.1.0 branch...
Nice that you explicitly handle the case of missing times. Do you expect a given mnemonic to either always have times or never, or for it to be more mixed?...
Well, if there were no actions, there's no reason to output the accumulated time in the first place. If there were actions (`numActions > 0`) but `systemTime.isEmpty()`, then the time...
A wrapper around the Accumulator/Adder that tracks validity would make sense. Then it could also have an interface that takes Duration and just use the long value internally.