buildtools icon indicating copy to clipboard operation
buildtools copied to clipboard

Cover missing cases during module extension label normalization

Open fmeum opened this issue 1 year ago • 5 comments

The previous logic missed to normalize cases such as "extension.bzl" and ":extension.bzl". Instead of enumerating cases, parse the label and track it in canonical form.

Related to https://github.com/bazelbuild/bazel/pull/20482

fmeum avatar Dec 09 '23 12:12 fmeum

CC @Wyverald

fmeum avatar Dec 09 '23 12:12 fmeum

Sorry, not familiar with this code base nor with Go.

larsrc-google avatar Dec 11 '23 12:12 larsrc-google

This is running into the same kind of likely unrelated CI failures on Windows as my other PR.

fmeum avatar Dec 20 '23 07:12 fmeum

@vladmos Friendly ping

fmeum avatar Mar 28 '24 10:03 fmeum

@vladmos Friendly ping

fmeum avatar Apr 18 '24 09:04 fmeum