Eric Larson

Results 1629 comments of Eric Larson

This error is emitted by Sphinx actually. So it suggests that the RST that there is an issue with consistency of header levels. Have you looked at the generated RST...

Do you have `plot_something.py` as an input file that SG renders into a `plot_something.rst`? Can you attach those?

I don't really understand the error message, there is no `minigallery` at all. You attached the `plot_something.py` that has this error: ``` /plot_something.py:1: CRITICAL: Title level inconsistent: My Title ^^^^^...

pre-commit.ci is failing, can you fix that and let me know then it's green and I'll approve other workflows/tests? > Do you think it would be better to encapsulate encapsulate...

> 3 of the test cases I added for test_traverse_directory are failing. Should I disable those lines for now? These test cases do not affect files retrieval, but make the...

Failure on Windows: ``` FAILED src/openneuro/tests/test_download.py::test_download_file_count[ds000117-include0-2626] - AssertionError: Expected 2626 files, got 5246 ```

You could use https://developer.microsoft.com/en-us/windows/downloads/virtual-machines/ Or this, but it's harder to iterate https://github.com/spyder-ide/spyder/blob/5aefe93cb6213b307e25e9eb32ab9c0c092aa039/.github/workflows/test-linux.yml#L82-L87

The failure on Windows is now gone... does that mean failures are intermittent? I'll try restarting CIs a few times

Okay I've rerun tests a few times on the merge commit as well as the one before it that failed previously and things are okay. +1 for merge from my...

@hoechenberger just a friendly reminder on this one