joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[5.3] Add PluginHelper::getPlugins() and deprecate old behavior

Open Hackwar opened this issue 1 year ago • 1 comments

Pull Request for Issue #44270.

Summary of Changes

PluginHelper::getPlugin() currently returns either an (empty) array of objects or a single object. This is the first step towards cleaning that code up by splitting the code up into a method to retrieve a single plugin (getPlugin()) and an array of plugins (getPlugins()).

Testing Instructions

Codereview.

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [ ] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [ ] No documentation changes for manual.joomla.org needed

Hackwar avatar Oct 16 '24 16:10 Hackwar

This pull request does not solve the issue of:

Warning: Attempt to read property "params" on array in [ROOT]libraries/src/Component/Router/Rules/MenuRules.php

The sef plugin must be enabled, always.

brbrbr avatar Oct 16 '24 19:10 brbrbr

This pull request does not solve the issue of:

Warning: Attempt to read property "params" on array in [ROOT]libraries/src/Component/Router/Rules/MenuRules.php

@brbrbr Test #44283

ghost avatar Oct 24 '24 07:10 ghost

When I see this code, then the plugin should either be booted or the PluginsModel should be used instead of introducing another static function with deprecated global static Factory calls.

laoneo avatar Nov 18 '24 09:11 laoneo

This pull request has been automatically rebased to 6.0-dev.

HLeithner avatar Mar 04 '25 17:03 HLeithner

This pull request has been automatically rebased to 6.1-dev.

HLeithner avatar Aug 31 '25 11:08 HLeithner