Jason Landini

Results 158 issues of Jason Landini

Added .clang-format for standardized style (issue #191)

When trying to include post-processed fields for time independent variables you run into a divide-by-zero error. This likely has to do with the initialization (or lack thereof) of the invM...

Type: Bug
Status: ⚠ High Priority

This is the first of a series of PRs aimed at refactoring the `matrixFreePDE` class into several compositional classes (e.g., discretization, timesteppings, etc.). This reduces the bulkiness of `matrixFreePDE` and...

refactoring

These applications no longer work (either deprecated or never implemented): - `_allenCahn_implicit` - `_nucleating_precipitates_MgRE` - `precipitateEvolution_pfunction` We can either remove them or mark them with a `[deprecated]_foldername` tag until they...

documentation

Add timer subsections for linear, nonlinear, and explicit, and aux solves (beyond the compute time in LHS & RHS) will be a useful diagnostic in assessing code performance & for...

Type: Feature
Status: Good first issue
Status: ⚠ Medium Priority

Adding the `[[maybe_unused]]` attribute can suppress compiler warnings if variables are not used (since [c++17](https://en.cppreference.com/w/cpp/language/attributes/maybe_unused)). https://github.com/prisms-center/phaseField/blob/5f4829aa30fc3e637f57f353e4179ea5d8f1446e/include/matrixFreePDE.h#L268-L276 We can use this for `q_point_loc` to suppress some the warnings since it won't...

good first issue

Maybe add some more clarity on where the string is coming from _Originally posted by @landinjm in https://github.com/prisms-center/phaseField/issues/262#issuecomment-2426959329_

Type: Error handling

Recently, I accidentally made an infinite while loop in #265 when I was doing what I thought to be a simple refactor (i.e., don't need to run the tests on...

Type: Bug
Status: ⚠ Medium Priority

Ninja (https://github.com/ninja-build/ninja) seems like a good alternative to Make for compiling. The main advantage of this is to reduce compile times when making incremental changes. I am unsure how it...

Type: Feature
Type: ❔ Question

Make it clear in the documentation when to use release and debug mode. Kinda like a best practices document.

Documentation: General