Lars Grüter

Results 496 comments of Lars Grüter

Thanks for the detailed performance report! scikit-image uses `scipy.ndimage.zoom` under the hood, so it's not surprising that the results are similar. I am curious why Pillow's resizing is so much...

Great points @rfezzani! Removing the bug label and adding potential "enhancement" instead.

In the meantime, what do you think about pointing out ``` img = np.array(Image.fromarray(im).resize(size)) ``` in the docstring as a fast alternative for if not all the bells and whistles...

@rgommers, thanks for taking a look! Now this is running into the same [`LONG_BIT` error](https://github.com/scikit-image/scikit-image/actions/runs/7180894298/job/19554131919?pr=7265#step:6:91) I see locally and mentioned in https://github.com/pyodide/pyodide/issues/4118. [You comment](https://github.com/numpy/numpy/pull/24603#issuecomment-1713509718) makes it seem that it may...

Thanks for investigating @stefanv. I just checked locally that this still seems to happen for the most recent pyodide-build versions 0.24.1 and 0.25.0a2 even though the fix https://github.com/pyodide/pyodide/pull/4136 should be...

Ha, apparently there is no need to use a `meson.cross` file together with `python -m build ...` for pyodide 0.25.0a2: `pyodide build` "just works"! :tada: Now I only need to...

Okay, now I'm getting loads of `OSError: [Errno 8] Bad file descriptor` which I can reproduce locally as well.

Status update: it's probably reasonable to wait with this until after NumPy 2.0 has settled. See https://github.com/numpy/numpy/pull/24603#issuecomment-1937394674.

Thanks for keeping us up to date. I was quietly following along but I think it still might make sense to wait with this until Pyodide includes NumPy 2.0 officially?...

> I would be glad to write a new PR that builds upon the changes here, or help out with code review here if needed. Please let me know what...