Jérôme Lafréchoux

Results 373 comments of Jérôme Lafréchoux

Thank you so much for looking into this! Regarding the OrderedSet type hints, feel free to send a PR even as draft, if only for history. Also, you might want...

Renamed Enum -> EnumSymbol, TypedEnum -> EnumValue. I'll squash later on. Docstrings still missing.

> What about `EnumValue(String)` and `EnumValue(Integer)`? That is consistent with `Nested`/`List` API, improves readability, and minimizes the API surface area. Just tried this and it worked a treat! I'm happy...

I think I'm done. @sloria @deckar01 @justanr I'll wait for a few days in case someone wants to review this and then I'll merge.

PR fixed. I'm not 100% happy with `self.field._serialize(m.value, None, None)` but that's our API.

Alright, moving on with this.

Just after merging this, as I was updating the changelog to release, I realized the naming didn't follow our habits of naming fields by object type. I pushed a new...

See #1322. It was not the initial intention when adding the `from_dict` feature. But it can still be discussed.

Thanks for the PR and sorry about the response delay. We didn't get the time to review thoroughly yet, but this looks good.

No objection. Could this be considered a breaking change? (Would a user actually pass "abcde" to exclude fields "a", "b", "c", "d", and "e"?) After a quick look, it appears...