Jérôme Lafréchoux

Results 373 comments of Jérôme Lafréchoux

Thanks @BenjaminNavarro for opening this. For the record, I opened [a discussion about this in Ardour forums](https://discourse.ardour.org/t/using-guitarix-with-ardour/106766). Nobody came up with a fantastic solution.

> The table alias problem is one I hadn't thought about before but totally makes sense. Good. Well, if you can improve this, it's great. The user experience would be...

Hi. Thanks for the help on this. I just changed ``` has_role(user: User, "c_member", campaign: Campaign) if ubc in campaign.users_by_campaigns and user = ubc.user; ``` into ``` has_role(user: User, "c_member",...

As I expected, I just got hit by this again. My model has this kind of loop / diamond relation (those loops always make me cringe but that how it...

FWIW, I just added ```py assert all((isinstance(v, str) for v in (error_messages or {}).values())) ``` at the beginning of `Field.__init__` and only `test_required_message_can_be_changed` breaks. This test dates back to #78...

Indeed, using a class rather than an instance should be safe. But it has the limitation that it doesn't allow the user to parametrize the nested schema with modifiers by...

I think the update in the original code is meant to allow a parent to update the nested schema context (as in #1791). The fix I propose breaks this. I...

I'm not familiar with cythonize. Does cythonization itself - without this PR - bring a significant improvement? Is there anything we could do to make it available more easily? Like,...

This could be a downside of https://github.com/marshmallow-code/marshmallow/issues/378 / https://github.com/marshmallow-code/marshmallow/pull/756. I didn't try, but AFAIU when default value was passed in serialized form, it was deserialized, so in this case the...

> Any reason not to change missing such that it get's passed to the respective fields rather than being returned by them? AFAIU, "passed to the respective fields" means "passed...