Jérôme Lafréchoux

Results 373 comments of Jérôme Lafréchoux

From those discussions - https://github.com/python/mypy/issues/3358 - https://github.com/python/mypy/issues/604 - https://github.com/python/mypy/pull/5677 Explicit `-> None` is needed if init func has no argument. I guess `*args` and `**kwargs` don't count. Form a quick...

Well, don't expect us to be quick to review and merge (see current backlog), but quality PRs are absolutely welcome. (And if you're good at type hinting, I wouldn't mind...

I tried to refactor the `get_value` method and couldn't find a way to support all cases. It's no surprise, this function has been thought and re-thought a few times already....

`from_field` already exists. It is the `attribute` parameter. We could add parameters `dump_method` and `load_method`. And deprecate `Method` field. And likewise `*_function`, unless there is a way to do both...

@lig you may open an issue for this, to see how the idea is received, and eventually work on a PR.

> I like the Meta auto-inheritance. It makes using a base Schema more practical. > > Maybe it can be achieved in another PR. I just opened a related RFC:...

LGTM. > Respect `missing_values` on serialization? What would that do? I'm tempted to say no. Do we do anything specific with `missing` already?

OK, I get it. Maybe it shouldn't be the same parameter. IIUC, the primary use case for this is an API for which it is complicated to enforce removal of...

> `default_values` is indeed misleading. If we go with https://github.com/marshmallow-code/marshmallow/issues/778 , we could do `load_default_values` and `dump_default_values`, I guess. Maybe we defer the serialization param for now. #1742 is about...