Christoph Läubrich

Results 1617 comments of Christoph Läubrich

@mickaelistria can you help converting this into a integration test?

@Kummallinen thanks for the test do you like to investigate if a temporary key can be generated and used for the test?

> What's the effect of that flag? Tycho always include requirements for a product, doesn't it? Product could have (intentionally or by accident) "missing" requirements and you can have feature...

@mickaelistria @akurtakov something for 2.7 release?

@parttimenerd we can add aJ17 JDK, but you should first change your test to require such one (e.g. by BREE requirement) if I remember right for example the test https://github.com/eclipse/tycho/tree/master/tycho-its/projects/compiler.jdt.bree.java8...

You should be able to run with J11 and habe a J17 jdk in the toolchains.xml, I'll try to prepare a change to enable this for the github actions.

See https://github.com/eclipse/tycho/pull/625/files It hard to guess what the test checks if it never fails for the current setup. If there is a problem with Java17 the code should show this...

Yeah it would be helpfull, you can wait right until J 17 support is enabled, or you can do it right now to proof Java 17 tests are nt yet...

> I changed my PR accordingly (and hopefully it works) Isn't the expectation that it fails? ;-)

@parttimenerd I have now enabled a true java 17 JDK and your test case is merged. @mickaelistria @akurtakov could you take a look at https://github.com/eclipse/tycho/tree/master/tycho-its/projects/compiler.extraExports.java17 I don't understand what to...