tycho icon indicating copy to clipboard operation
tycho copied to clipboard

Example to reproduce #1261

Open Kummallinen opened this issue 3 years ago • 7 comments
trafficstars

Example p2 repo which reproduces #1261, requested in PR #1268

Building this repo requires an environment already set up to PGP sign artifacts, the key name & password server ID need to be passed via the test-pgp-key.name & test-pgp-key.serverId properties.

Kummallinen avatar Aug 16 '22 14:08 Kummallinen

@mickaelistria can you help converting this into a integration test?

laeubi avatar Aug 16 '22 14:08 laeubi

I don't think I'll spend time to make it an automated test, particularly since it requires to setup gpg on the CI and so on, it's more work than what I'm able to spend these days. The other PR is relatively safe and this part of the code is not too fragile, so we can live without a test for the moment. If someone feels like they can make it an automated test, please do it; if not, please close this PR.

mickaelistria avatar Aug 22 '22 09:08 mickaelistria

@Kummallinen thanks for the test do you like to investigate if a temporary key can be generated and used for the test?

laeubi avatar Sep 08 '22 05:09 laeubi

@Kummallinen thanks for the test do you like to investigate if a temporary key can be generated and used for the test?

I can look into it but won't have the time for a few weeks. From my experiences using the gig plugin in my own builds I think getting the temporary key into a usable key ring would be the sticking point.

Kummallinen avatar Sep 08 '22 09:09 Kummallinen

I think @merks has already done some tests with temporary PGP key, maybe the aproach can be reused/adapted for a test here? @Kummallinen do you like to finish this PR so we can include it in the regular checks?

laeubi avatar May 18 '23 04:05 laeubi

Test Results

  579 files  ±0    579 suites  ±0   3h 51m 58s :stopwatch: + 12m 14s   392 tests ±0    385 :white_check_mark: +2   7 :zzz: ±0  0 :x:  - 2  1 176 runs  ±0  1 154 :white_check_mark: +3  22 :zzz: ±0  0 :x:  - 3 

Results for commit 49761110. ± Comparison against base commit e28d416a.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 18 '23 06:05 github-actions[bot]

Closing as no further feedback from original author @Kummallinen if this is still interesting for you please let me know so we can reopen the PR.

laeubi avatar May 05 '24 17:05 laeubi