ladeak comments

Results 90 comments of


                                            ladeak

Matching type names of the sample server interceptors

@JamesNK could you review the changes?

Matching type names of the sample server interceptors

@JamesNK could you review the changes?

HttpSys request headers Keys and Count both allocate

I submitted the benchmarks. In my original benchmarks I actually reused a captured `NativeMemory` - which meant I had 3 KB byte array in the source. I updated these benchmarks...

HttpSys request headers Keys and Count both allocate

@Tratcher and @BrennanConroy please review changes.

HttpSys request headers Keys and Count both allocate

Yes, I have rebased, but eventually not used that infra. Although that simplified two of the tests (did not need to workaround removed header's)

HttpSys request headers Keys and Count both allocate

I pushed an update, but it is getting late here. Let me run re-run the performance tests tomorrow.

HttpSys request headers Keys and Count both allocate

**EDIT 2022. 11. 29. : this is obsolete** @Tratcher I have rebased to include your latest changes. I addressed all comments. I fixed some space/tabs styling in the .tt file....

HttpSys request headers Keys and Count both allocate

I am looking into it.

HttpSys request headers Keys and Count both allocate

The current performance results: ``` | Method | Job | Toolchain | RunStrategy | Mean | Error | StdDev | Op/s | Gen 0 | Gen 1 | Gen 2...

HttpSys request headers Keys and Count both allocate

@Tratcher I am sorry, but I ended up force pushing against my original intentions :(