ladeak

Results 90 comments of ladeak

@amcasey , I added a commit that has a new limit on `KestrelServerLimits`, and this is also respected by `Http2FrameWriter`. I think the code ended up quite a bit complicated...

> Assuming no perf impact, I would probably accept that level of complexity to get the extra protection. Having said that, it feels like there are ways we could reduce...

I am thinking (and moving - wip) the limit logic to `HttpProtocol` after the headers collection is marked readonly. I believe it is going to be a common place for...

> I was actually thinking of a single check for _each_ protocol, but I'm fine with merging the checks if that's an option. In `HttpProtocol` I would need to iterate...

@amcasey (and @mgravell ) I moved the size validation into `HPackHeaderWriter`. It is using the payload length when available from the underlying HPack encoder, or it 'calculates' a header size...

> @ladeak I still feel like I'm missing something fundamental. It seems like the input to the writer is a collection of header names and values. Is that correct? Maybe...

> While I was out, I had some chance to look at the HTTP/2 spec and noticed that [8.2.3](https://datatracker.ietf.org/doc/html/rfc9113#section-8.2.3) gives us another way to split up long headers. Do you...

@amcasey , 1, Does it bother you that I click resolve comment when I push an update on the given comment? (I do it only so that I can track...

@amcasey , no need to be sorry, the plan sounds reasonable to me.

I have tried both using `https://www.nuget.org/packages/ErikEJ.EntityFramework.SqlServer` from @ErikEJ and building this repository. When I built the *main* branch of this repository, I noticed a few "breaking" changes that were captured...