Kyle O'Brien

Results 12 comments of Kyle O'Brien

@Baachi - there is no setStrict on the ValidatorStep class. There is one on the ValidatorFilter but since the Workflow doesn't seem to be a concretion anymore, I can only...

@Baachi - if I implement the isStrict logic in ValidatorStep as it's done on ValidatorFilter, then setting isStrict(false) works great. Should I push a PR for this or is there...

Thanks @Baachi. One thing - I'm unsure how [ValidatorFilter](https://github.com/ddeboer/data-import/blob/master/src/Filter/ValidatorFilter.php) features in the new [Workflow](https://github.com/ddeboer/data-import/blob/master/src/Workflow.php). In 0.18 we had a concrete [Workflow](https://github.com/ddeboer/data-import/blob/master/src/Workflow.php) class. That class had `addFilter`. However, in 0.19.0, the...

@kuzmamar - could you perhaps open a PR for your suggested change?

@stevenbuehner - why not create a pull request with your changes? Might be better

@Charlemagne3 - sorry for the delay on this. I think this is a great idea. Still looking at the PR but I noticed there is no documentation update. I think...

@CoffeeJack - I think this is a very valid concern. Let's see - perfect scenario, how would you like that represented in a converted data structure? So, text like the...

@mackeyja92 - I'm currently working on a rollout for this using the current parser and renderer already inherent in the code. I'm happy to continue with that if you've not...

@H0neyBadger - sorry for the super delayed response here. I just want to check in with you if you remember if and how this was resolved on your end and...

@davidfischer-ch - stil interested in making those small changes so we can merge this? - add a test - add some coverage about this in the documentation