django-rest-framework-xml icon indicating copy to clipboard operation
django-rest-framework-xml copied to clipboard

Published 20 hours ago • verified publisher icon jpadilla

Make XML generator class overridable

Open davidfischer-ch opened this issue 10 years ago • 6 comments

davidfischer-ch avatar Jun 18 '15 13:06 davidfischer-ch

@davidfischer-ch thanks! A small test and update the docs would make this even better.

jpadilla avatar Jun 18 '15 13:06 jpadilla

Sure, I will !

davidfischer-ch avatar Jun 18 '15 14:06 davidfischer-ch

@davidfischer-ch - stil interested in making those small changes so we can merge this?

  • add a test
  • add some coverage about this in the documentation

kyleobrien91 avatar Mar 10 '17 08:03 kyleobrien91

Hello,

Unfortunately I didn't have time to do so, but this "design pattern" is so common in the Python world ... Is it really needed to write test and doc?

Thanks.

davidfischer-ch avatar Apr 09 '17 20:04 davidfischer-ch

Hello :)

really want to push this PR. I'm pretty much at the same position and need to override the short_empty_elements flag on XMLGenerator initialization.

Is it possible to support you on brining this PR fast into master? :)

jkblume avatar Jul 16 '18 23:07 jkblume

Hello,

I just resolved the conflict.

davidfischer-ch avatar Jul 17 '18 05:07 davidfischer-ch